Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(gatsby-plugin-sass): plugin option issues #27796

Closed
cpboyd opened this issue Nov 2, 2020 · 1 comment · Fixed by #27822
Closed

bug(gatsby-plugin-sass): plugin option issues #27796

cpboyd opened this issue Nov 2, 2020 · 1 comment · Fixed by #27822
Assignees
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@cpboyd
Copy link
Contributor

cpboyd commented Nov 2, 2020

Description

Per https://sass-lang.com/documentation/js-api#outputstyle:
While nested is the default for Node Sass, it isn't supported by Dart Sass.

Similarly, webpackImporter is no longer allowed. This is necessary for any Sass files using @forward syntax (e.g. Google's Material design): webpack-contrib/sass-loader#804

This breaking change was introduced in #27437.

Steps to reproduce

Setup with Dart Sass as described on https://www.gatsbyjs.com/plugins/gatsby-plugin-sass/

Expected result

This should work, as it used to.

Actual result

Invalid argument(s): Unsupported output style "nested".

Environment

  System:
    OS: macOS 11.0.1
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.0.1 - /usr/local/bin/node
    npm: 7.0.3 - /usr/local/bin/npm
  Languages:
    Python: 2.7.16 - /usr/bin/python
  Browsers:
    Chrome: 86.0.4240.111
    Edge: 86.0.622.58
    Firefox: 80.0.1
    Safari: 14.0.1
  npmPackages:
    gatsby-theme-youtube: ^1.0.0 => 1.0.0 
  npmGlobalPackages:
    gatsby-cli: 2.12.104
@cpboyd cpboyd added the type: bug An issue or pull request relating to a bug in Gatsby label Nov 2, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 2, 2020
@cpboyd cpboyd changed the title bug(gatsby-plugin-sass): default outputStyle of nested is not supported by Dart Sass bug(gatsby-plugin-sass): plugin option issues Nov 2, 2020
@LekoArts LekoArts added topic: sass and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 3, 2020
@pravinthan
Copy link

The cssLoader option validation is missing too, causing some Gatsby projects to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants