fix(plugin-manifest): Allow for all valid WebAppManifest properties (#27951) #28099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…27951) * bring in complete(albeit outdated) WebAppManifest validation frrom previous unmerged PR * Cleanup Gatsby Plugin Options * update validation to match recent spec changes * update compatible gatsby version * reomve unused service worker object and fix numberic string * lint * add details from suplementry spec * final return * Prettify Co-authored-by: Max Stoiber <contact@mxstbr.com> (cherry picked from commit 88b990a)
gatsbot
bot
added
the
status: triage needed
vladar
added
type: cherry
and removed
status: triage needed
vladar
commented
Nov 16, 2020
| @@ -32,7 +32,7 @@ | |||
| "license": "MIT", | |||
| "main": "index.js", | |||
| "peerDependencies": { | |||
| "gatsby": "^2.25.0" | |||
| "gatsby": "^2.4.0" | |||
There was a problem hiding this comment.
Reverted this for the release branch for additional safety. This bump will go to the next minor.
pvdz
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #27951 to the release branch
(cherry picked from commit 88b990a)