fix(gatsby-link): don't prefetch same page #28307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
commented
Nov 26, 2020
wardpeet
commented
Nov 26, 2020
LekoArts
removed
the
status: triage needed
|
This looks great! Thanks for doing this so quickly @wardpeet ! |
wardpeet
commented
Nov 26, 2020
TylerBarnes
approved these changes
Nov 26, 2020
|
We can hotfix it :) |
|
Awesome :D |
pieh
pushed a commit
that referenced
this pull request
Nov 26, 2020
* fix(gatsby-link): don't prefetch same page * test prefect intersection-observer Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
pieh
pushed a commit
that referenced
this pull request
Nov 26, 2020
* fix(gatsby-link): don't prefetch same page * test prefect intersection-observer Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 3666130)
|
@wardpeet, @TylerBarnes PR backporting this to 2.27 release - #28313 |
vladar
pushed a commit
that referenced
this pull request
Nov 26, 2020
|
Published in |
|
Thanks @vladar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When prefetching a url that's already being fetched can end up in a race-condition where the browser looks into it's prefetch cache.
You can end up with stale data.
How can this happen?
If you have a gatsby-link component with the same url as the current page.
This is an issue when using wordpress preview
I've added tests to make sure we test this behaviour
On the demo you see that the prefetch cached network request wins over the new request
