Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): fix gatsby develop on windows #31396

Merged
merged 1 commit into from May 13, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 12, 2021

Description

Current code doesn't work as expected on windows as requestPath result in in values like /src\\pages\\test.mdx and apparently webpack looses backslashes along the way (?)

In any case, good old slash to use slashes instead fixes the issue

Related Issues

fixes #31392

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 12, 2021
@pieh pieh added topic: MDX and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 12, 2021
@vladar vladar added this to To cherry-pick in V3 Release Hotfixes via automation May 13, 2021
@vladar vladar merged commit ae2e2de into master May 13, 2021
@vladar vladar deleted the fix/windows/mdx-develop branch May 13, 2021 10:00
@pelikhan
Copy link

is this fix in the v3.5 release? It defintely breaks any gatsby site using MDX on windows.

vladar pushed a commit that referenced this pull request May 19, 2021
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes May 19, 2021
vladar added a commit that referenced this pull request May 19, 2021
(cherry picked from commit ae2e2de)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes May 19, 2021
@vladar vladar moved this from Backported to Published in V3 Release Hotfixes May 19, 2021
@vladar
Copy link
Contributor

vladar commented May 19, 2021

Published in gatsby-plugin-mdx@2.5.1

@LekoArts LekoArts removed this from Published in V3 Release Hotfixes May 27, 2021
@hasparus
Copy link
Contributor

hasparus commented Jun 10, 2021

I still have this problem while using 2.5.1.

hasparus added a commit to system-ui/theme-ui that referenced this pull request Jun 10, 2021
2.5.1 is still broken on Windows.

See gatsbyjs/gatsby#31396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-mdx 2.5.x breaks npm gatsby init when mdx file added
4 participants