Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump babel minor #31857

Merged
merged 3 commits into from Jun 10, 2021
Merged

chore(deps): bump babel minor #31857

merged 3 commits into from Jun 10, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jun 10, 2021 •
edited

Description

Babel bump in #31143 upgrades to different minor versions of babel: some packages upgraded to 7.14, some to 7.13 and for others, it keeps 7.12.

Looks like it confuses yarn when upgrading from older version of gatsby to gatsby 3.7.0

[1/4] Why do we have the module "@babel/plugin-proposal-class-properties"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "@babel/plugin-proposal-class-properties@7.13.0"
info Reasons this module exists
   - "gatsby#babel-preset-gatsby" depends on it
   - Hoisted from "gatsby#babel-preset-gatsby#@babel#plugin-proposal-class-properties"

=> Found "@babel/preset-env#@babel/plugin-proposal-class-properties@7.14.5"
info This module exists because "gatsby#babel-preset-gatsby#@babel#preset-env" depends on it.

This PR attempts to use the same latest minor version of babel for all gatsby packages. That could still cause issues if upstream dependencies rely on earlier minor versions. But at least our own packages won't be conflicting.

Fixes #31853

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 10, 2021
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 10, 2021
@vladar vladar added this to To cherry-pick in V3 Release Hotfixes via automation Jun 10, 2021
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 10, 2021
@gatsbybot gatsbybot merged commit 7d42e8d into master Jun 10, 2021
@gatsbybot gatsbybot deleted the vladar/bump-babel branch June 10, 2021 12:53
vladar added a commit that referenced this pull request Jun 10, 2021
@vladar
chore(deps): bump babel minor (#31857)
7b341b7
@vladar vladar mentioned this pull request Jun 10, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Jun 10, 2021
vladar added a commit that referenced this pull request Jun 10, 2021
@vladar
chore(deps): bump babel minor (#31857) (#31859)
8636025
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Jun 10, 2021
@vladar vladar moved this from Backported to Published in V3 Release Hotfixes Jun 10, 2021
@vladar
Copy link
Contributor Author

vladar commented Jun 10, 2021

Published in gatsby@3.7.1

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@vladar
chore(deps): bump babel minor (gatsbyjs#31857)
c199608 
* chore(deps): bump babel minor

* run yarn-deduplicate

* re-run yarn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing class properties transform
3 participants
@vladar @wardpeet @gatsbybot