Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(babel-preset-gatsby): no compile #32713

Merged
merged 2 commits into from Aug 6, 2021
Merged

fix(babel-preset-gatsby): no compile #32713

merged 2 commits into from Aug 6, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Aug 5, 2021

Description

By adding a typescript file to gatsby-babel-preset-package it can cause problems when it's not build. So we can't make this package typescript.
I moved it back to plain js

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 5, 2021
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) labels Aug 6, 2021
@wardpeet wardpeet merged commit 850a5ea into master Aug 6, 2021
@wardpeet wardpeet deleted the fix/babel-preset-gatsby-package-noncompile branch August 6, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: webpack/babel Webpack or babel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wardpeet @LekoArts