test: adjust tests after the bump #33171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
status: blocked
gatsbot
bot
added
the
status: triage needed
This reverts commit 4d7a20c.
pieh
removed
the
status: triage needed
pieh
commented
Sep 14, 2021
| @@ -26,7 +26,8 @@ | |||
| "@babel/core": "^7.15.5", | |||
| "@babel/helper-plugin-test-runner": "7.14.5", | |||
| "@babel/plugin-transform-modules-commonjs": "^7.15.4", | |||
| "@types/babel__core": "^7.1.15" | |||
| "@types/babel__core": "^7.1.15", | |||
| "cross-env": "^7.0.3" | |||
There was a problem hiding this comment.
cross-env used in prepare script, but not declared in devDeps
pieh
commented
Sep 14, 2021
Comment on lines
-15
to
+43
| const pluginSchema = pluginSchemaFunction({ Joi }) | ||
| const pluginSchema = pluginSchemaFunction({ | ||
| Joi: Joi.extend(joi => { | ||
| return { | ||
| base: joi.any(), | ||
| type: `subPlugins`, | ||
| args: (): any => | ||
| joi | ||
| .array() | ||
| .items( | ||
| joi | ||
| .alternatives( | ||
| joi.string(), | ||
| joi.object({ | ||
| resolve: Joi.string(), | ||
| options: Joi.object({}).unknown(true), | ||
| }) | ||
| ) | ||
| .custom(value => { | ||
| if (typeof value === `string`) { | ||
| value = { resolve: value } | ||
| } | ||
|
|
||
| return value | ||
| }, `Gatsby specific subplugin validation`) | ||
| ) | ||
| .default([]), | ||
| } | ||
| }), | ||
| }) |
There was a problem hiding this comment.
test helper wasn't aware of .subPlugins so this adds smaller stub that pretty much just checks for valid structure
pieh
commented
Sep 14, 2021
| @@ -56,6 +56,7 @@ describe(`calcDirtyHtmlFiles`, () => { | |||
| // eslint-disable-next-line @typescript-eslint/naming-convention | |||
| pluginCreator___NODE: `foo`, | |||
| updatedAt: 1, | |||
| mode: `SSG`, | |||
There was a problem hiding this comment.
mocked pages are not using createPage action creator, so we fallback/defaultmode is not set
… in plugin options
|
not everything fixed, but merging this in as at least unit tests on linux are happy (and e2e/integration tests actually run now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Related Issues