fix(gatsby): Remove GATSBY_BUILD_STAGE & warn against ___NODE
#33501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
wardpeet
reviewed
Oct 12, 2021
vladar
reviewed
Oct 13, 2021
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
wardpeet
approved these changes
Oct 13, 2021
d4v1d82
added a commit
to d4v1d82/gatsby-plugin-loadable-components-ssr
that referenced
this pull request
Oct 22, 2021
replace process.env.GATSBY_BUILD_STAGE with process.env.BUILD_STAGE gatsbyjs/gatsby#33501
wardpeet
added a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
…tsbyjs#33501) Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
…3501) Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GATSBY_BUILD_STAGEenvironment variable___NODEconvention is usedTODO: In Gatsby v2, the NodeInput.id field is of type String, not ID.since decided to keep itPreview:
Documentation
GATSBY_BUILD_STAGEwill be added to migration guide after merged