fix(gatsby-source-filesystem): use correct hash when using createFileNodeFromBuffer #35243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 29, 2022 15:27
…teFileNodeFromBuffer (#35242)
gatsbot
bot
added
the
status: triage needed
2 tasks
wardpeet
changed the title
wardpeet
changed the title
wardpeet
changed the title
wardpeet
approved these changes
Mar 30, 2022
wardpeet
added
topic: source-plugins
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the inconsistency within
createFileNodeFromBuffer()function ofgatsby-source-filesystemif a hash is calculated and not provided.The
nameargument of this function has a default value ofhash. However, thehashparameter is optional. if not given, it is calculated within the same function. In this case,nameremainsundefined, which throws an error whencreateFilePath()is called.In previous versions of Gatsby, the behaviour was also consistent, but didn't throw an error. In stead, the filename would have been
undefined.This pull request fixes that inconsistency by setting the
namedefault after calculating the hash.I also added two tests:
hashis given butnameisn'thashnornameis given (which would fail without this fix)Documentation
This behavior was undocumented. I added a note about it to the README.md of gatsby-source-filesystem.
Related Issues
Addresses #35242