Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Handle immediate unmount #35878

Merged
merged 4 commits into from
Jun 8, 2022
Merged

fix(gatsby-plugin-image): Handle immediate unmount #35878

merged 4 commits into from
Jun 8, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jun 8, 2022 •
edited

Description

Handle scenario in gatsby-plugin-image where the component is immediately unmounted before GatsbyImageHydrator has a chance to create the element and assign the ref.

Also moves static image e2e tests into dev and prod runtime suites. Prior we did not test static image behavior with gatsby develop.

Documentation

N/A

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 8, 2022
@tyhopp tyhopp added topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 8, 2022
@tyhopp tyhopp requested a review from wardpeet June 8, 2022 04:10
LekoArts
LekoArts previously approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts added this to To cherry-pick in V4 Release hotfixes via automation Jun 8, 2022
@LekoArts LekoArts added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 8, 2022
LekoArts
LekoArts approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LekoArts LekoArts merged commit fbdec7e into master Jun 8, 2022
@LekoArts LekoArts deleted the fix-gatsby-plugin-image-immediate-unmount branch June 8, 2022 10:07
marvinjude pushed a commit that referenced this pull request Jun 8, 2022
@tyhopp @marvinjude
fix(gatsby-plugin-image): Handle immediate unmount (#35878)
54dda28 
(cherry picked from commit fbdec7e)
@gatsbybot gatsbybot mentioned this pull request Jun 8, 2022
Merged
@marvinjude marvinjude moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Jun 8, 2022
marvinjude pushed a commit that referenced this pull request Jun 8, 2022
@ViCo0TeCH @tyhopp
fix(gatsby-plugin-image): Handle immediate unmount (#35878) (#35883)
e2cf510 
(cherry picked from commit fbdec7e)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
@marvinjude marvinjude moved this from Backport PR opened to Backported in V4 Release hotfixes Jun 8, 2022
@LekoArts LekoArts moved this from Backported to Published in V4 Release hotfixes Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
V4 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyhopp @LekoArts