Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor meta.state access in gatsby-source-filesystem #36355

Merged

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Aug 10, 2022

We might introduce a simpler way to access this information in the future that wouldn't require this redundant~ assign. For the time being this is what I would do here though

cc @LekoArts

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 10, 2022
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 10, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, appreciate it!

@LekoArts LekoArts merged commit 84db263 into gatsbyjs:fix-xstate-option Aug 10, 2022
@Andarist Andarist deleted the fix/source-filesystem-machine branch August 10, 2022 13:16
pieh pushed a commit that referenced this pull request Nov 17, 2022
…#36342)

* update version and fix types

* yolo add option

* Work around removal of meta.state

* Refactor `meta.state` access in `gatsby-source-filesystem` (#36355)

Co-authored-by: Lennart <lekoarts@gmail.com>

* fix ts-ignore

* Upgrade XState to the latest 4.33.3 (#36451)

* update to latest xstate

* Use `pendingQueryRuns` available on the event (#36393)

* Revert "Use `pendingQueryRuns` available on the event (#36393)"

This reverts commit 9460dd3.

Co-authored-by: tyhopp <hopp.ty.c@gmail.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
…gatsbyjs#36342)

* update version and fix types

* yolo add option

* Work around removal of meta.state

* Refactor `meta.state` access in `gatsby-source-filesystem` (gatsbyjs#36355)

Co-authored-by: Lennart <lekoarts@gmail.com>

* fix ts-ignore

* Upgrade XState to the latest 4.33.3 (gatsbyjs#36451)

* update to latest xstate

* Use `pendingQueryRuns` available on the event (gatsbyjs#36393)

* Revert "Use `pendingQueryRuns` available on the event (gatsbyjs#36393)"

This reverts commit 9460dd3.

Co-authored-by: tyhopp <hopp.ty.c@gmail.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants