Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin xstate #36398

Merged
merged 3 commits into from Aug 17, 2022
Merged

chore: pin xstate #36398

merged 3 commits into from Aug 17, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Aug 17, 2022

Description

xstate@4.33.0 introduced console warning about flag that will become future default, while trying to migrate to use it we found some quirks that don't seem to be ironed out fully ( #36342 (comment) ) and might still change so for now (until there is clarity on those quirks) let's pin xstate.

This also adds some unit tests to query-running machine in particular around things that change behavior

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 17, 2022
@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 17, 2022
@LekoArts LekoArts added this to To cherry-pick in V4 Release hotfixes via automation Aug 17, 2022
@pieh pieh merged commit 6e4a0de into master Aug 17, 2022
@pieh pieh deleted the xstate/pin branch August 17, 2022 10:49
marvinjude pushed a commit that referenced this pull request Aug 18, 2022
Co-authored-by: LekoArts <lekoarts@gmail.com>
(cherry picked from commit 6e4a0de)
marvinjude pushed a commit that referenced this pull request Aug 18, 2022
Co-authored-by: LekoArts <lekoarts@gmail.com>
(cherry picked from commit 6e4a0de)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@marvinjude marvinjude moved this from To cherry-pick to Backported in V4 Release hotfixes Aug 19, 2022
@marvinjude marvinjude moved this from Backported to Published in V4 Release hotfixes Aug 19, 2022
@marvinjude
Copy link
Contributor

Published in gatsby@4.21.1

@tyhopp tyhopp removed this from Published in V4 Release hotfixes Sep 13, 2022
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Co-authored-by: LekoArts <lekoarts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants