chore(gatsby): upgrade latest-version #36434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
type: maintenance
|
This package is ESM-only now and requires additional changes to how it's imported and used |
pieh
added
the
status: blocked
… to commonjs right now
pieh
force-pushed
the
chore/upgrade/latest-version
branch
from
28b0fcf
to
66dd212
Compare
pieh
removed
the
status: blocked
pieh
commented
Oct 17, 2022
Comment on lines
-6
to
+8
| presets: [["babel-preset-gatsby-package"]], | ||
| presets: [["babel-preset-gatsby-package", { | ||
| keepDynamicImports: [`./src/utils/feedback.ts`] | ||
| }]], |
There was a problem hiding this comment.
this PR adds a way to mark individual files to not transform
await import("")
to
await Promise.resolve().then(() => _interopRequireWildcard(require("")));
and instead keep dynamic import
We have plenty of dynamic imports in our codebase / gatsby package and switching it everywhere (through already existing esm: true option that babel-preset-gatsby-package) doesn't seem like good idea and definitely would require solid testing.
This approach allows us to address individual modules and we can over-time migrate more things if needed
pieh
commented
Oct 17, 2022
| [path.resolve(__dirname, "../../babel-transform-compiler-flags.js"), | ||
| [path.resolve(__dirname, "../../../babel-transform-compiler-flags.js"), |
There was a problem hiding this comment.
this was moved from top-level for all fixtures to one directory below that, hence path adjustment
pieh
commented
Oct 17, 2022
| function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; } | ||
|
|
||
| async function someFunction() { | ||
| return await Promise.resolve().then(() => _interopRequireWildcard(require(`path`))); |
There was a problem hiding this comment.
ensuring default doesn't change to not introduce accidental regressions
pieh
commented
Oct 17, 2022
| exports.someFunction2 = someFunction2; | ||
|
|
||
| async function someFunction2() { | ||
| return await import(`path`); |
There was a problem hiding this comment.
this file was marked to keep dynamic import in
and it in fact keep that instead of doing transformation
LekoArts
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates to latest of ...
latest-version- this package requiresnode@>=14.16, which we couldn't do in v4 due to us being on minimalnode@14.15Related Issues
[ch54713]