chore(tests): setup circleci to run unit tests againt v5 #36714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
type: maintenance
pieh
changed the title
pieh
commented
Oct 3, 2022
Comment on lines
-306
to
+313
| // The second param is a "hint", see: https://jestjs.io/docs/en/expect#tomatchsnapshotpropertymatchers-hint | ||
| expect(results).toMatchSnapshot({}, `results`) | ||
| expect(reporter.warn.mock.calls).toMatchSnapshot({}, `warn`) | ||
| expect(reporter.panicOnBuild.mock.calls).toMatchSnapshot({}, `panicOnBuild`) | ||
| expect({ | ||
| results, | ||
| warnCalls: reporter.warn.mock.calls, | ||
| panicOnBuildCalls: reporter.panicOnBuild.mock.calls, | ||
| }).toMatchSnapshot() |
There was a problem hiding this comment.
this was failing with "obsolete snapshots" even tho jest is supposed to not fail on it when there are snapshots in skipped tests ( jestjs/jest#3038 ). Seems like either using multiple snapshots and/or using the named ones is edge case, so I used single snapshot here instead
pieh
commented
Oct 3, 2022
| postfix: `SortInputProp2`, | ||
| postfix: `SortInput`, |
There was a problem hiding this comment.
This is actual v5 code fix that slipped through original PR ( #36708 )
imjoshin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Related Issues