Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby,gatsby-cli): Slice component validation #36801

Merged
merged 6 commits into from Oct 13, 2022
Merged

feat(gatsby,gatsby-cli): Slice component validation #36801

merged 6 commits into from Oct 13, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Oct 12, 2022 •
edited

Description

  • DRY existing validation from createPage so it can be used in createSlice
  • Add component validation to createSlice
  • Add tests for validation logic

Documentation

N/A

Related Issues

[sc-56600]

@tyhopp tyhopp added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label Oct 12, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 12, 2022
@tyhopp tyhopp marked this pull request as draft October 12, 2022 04:45
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 12, 2022
Base automatically changed from v5-patches to master October 12, 2022 16:45
@tyhopp tyhopp force-pushed the feat/slices-no-default-export-errors branch from ba07be6 to de0ef28 Compare October 13, 2022 02:07
@tyhopp tyhopp marked this pull request as ready for review October 13, 2022 04:03
@tyhopp tyhopp added this to the Gatsby 5 milestone Oct 13, 2022
@LekoArts LekoArts merged commit 1fd450f into master Oct 13, 2022
@LekoArts LekoArts deleted the feat/slices-no-default-export-errors branch October 13, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
Gatsby 5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyhopp @LekoArts