Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-gatsby-cloud): Re-add constant LINK_REGEX #36839

Merged
merged 1 commit into from Oct 18, 2022
Merged

fix(gatsby-plugin-gatsby-cloud): Re-add constant LINK_REGEX #36839

merged 1 commit into from Oct 18, 2022

Conversation

aghreed
Copy link
Contributor

@aghreed aghreed commented Oct 17, 2022 •
edited by LekoArts

Description

This PR re-introduces the LINK_REGEX constant that I believe was erroneously removed here: https://github.com/gatsbyjs/gatsby/pull/35586/files#diff-3cfde586499cf0544b902496d3bfc2636c027a2d5d750bc4099083265a767548L40

Documentation

I don't believe any documentation needs updated, but the relevant doc is here: https://www.gatsbyjs.com/plugins/gatsby-plugin-gatsby-cloud/#headers

Related Issues

Fixes #36624

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 17, 2022
@aghreed aghreed added type: bug An issue or pull request relating to a bug in Gatsby topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 17, 2022
@aghreed aghreed requested a review from dmccraw October 17, 2022 20:59
dmccraw
dmccraw approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@dmccraw dmccraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@LekoArts LekoArts removed the type: bug An issue or pull request relating to a bug in Gatsby label Oct 18, 2022
@LekoArts LekoArts added this to To cherry-pick in V4 Release hotfixes via automation Oct 18, 2022
@LekoArts LekoArts changed the title fix: re-add constants export LINK_REGEX that was missing fix(gatsby-plugin-gatsby-cloud): Re-add constant LINK_REGEX Oct 18, 2022
@LekoArts LekoArts merged commit 7dd02a9 into master Oct 18, 2022
@LekoArts LekoArts deleted the fix/gatsby-plugin-gatsby-cloud-link-remove-unhashed branch October 18, 2022 08:46
@gatsbybot gatsbybot mentioned this pull request Oct 19, 2022
Merged
LekoArts pushed a commit that referenced this pull request Oct 19, 2022
@aghreed @LekoArts
fix(gatsby-plugin-gatsby-cloud): Re-add constant LINK_REGEX (#36839)
101573b 
(cherry picked from commit 7dd02a9)
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Oct 19, 2022
LekoArts pushed a commit that referenced this pull request Oct 19, 2022
@ViCo0TeCH @aghreed
fix(gatsby-plugin-gatsby-cloud): Re-add constant LINK_REGEX (#36839) (#…
d211a97 
…36847)

Co-authored-by: Alex Reed <alex.reed@gatsbyjs.com>
@LekoArts LekoArts moved this from Backport PR opened to Backported in V4 Release hotfixes Oct 19, 2022
@LekoArts LekoArts moved this from Backported to Published in V4 Release hotfixes Oct 19, 2022
@LekoArts
Copy link
Contributor

Published in gatsby-plugin-gatsby-cloud@4.24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmccraw dmccraw dmccraw approved these changes

Assignees
No one assigned
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
V4 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-gatsby-cloud: LINK_REGEX constant is missing; Link header replacements don't work
3 participants
@aghreed @LekoArts @dmccraw