fix: Move murmurhash to gatsby-core-utils #36882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
wardpeet
reviewed
Oct 25, 2022
| @@ -20,5 +20,6 @@ export { listPlugins } from "./list-plugins" | |||
| export { createFilePath } from "./filename-utils" | |||
| export { readConfigFile, getConfigPath } from "./utils" | |||
| export { lock } from "./lock" | |||
| export { murmurhash } from "./murmurhash" | |||
There was a problem hiding this comment.
should we export? Maybe we shouldn't have a global export casue nodejs doesn't tree-shake
There was a problem hiding this comment.
I guess this would be something for the package as a whole, not only for the murmurhash
wardpeet
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves
murmurhashfrombabel-plugin-remove-graphql-queriestogatsby-core-utils. Because this is where this util should really live (and makes it easier to modify the babel plugin in the future).Related Issues
[ch55257]