fix(gatsby-cli): Fine-grained errors with type/category #37070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
changed the title
LekoArts
commented
Nov 21, 2022
Comment on lines
25
to
26
| type: `UNKNOWN`, | ||
| level: `ERROR`, |
There was a problem hiding this comment.
Since both are optional for plugins (current behavior) but required internally, we're setting default values here
pieh
reviewed
Nov 22, 2022
Comment on lines
-83
to
+92
| type: Type.WEBPACK, | ||
| // TODO: The type needs to be better | ||
| type: Type.UNKNOWN, |
There was a problem hiding this comment.
Is this because the error could be for bunch of different webpack stages and because of that we can't assign type here? For the follow up we would create specific code ids for each stage then?
There was a problem hiding this comment.
Correct. We'd need to make type also optionally accept the context so that we can for each stage have an error
pieh
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forces the existence of
typeandcategoryon our internal errorMap. Makes thetypemore fine-grained.Documentation
No public API changes, so no docs changes needed.
Related Issues
[ch58451]
[ch58452]