feat(gatsby-source-drupal): add typePrefix option
#37967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
commented
Apr 21, 2023
ascorbic
commented
Apr 21, 2023
Comment on lines
-798
to
-803
| store, | ||
| cache, | ||
| createNode, | ||
| createNodeId, | ||
| getCache, | ||
| reporter, |
There was a problem hiding this comment.
These aren't valid props
ascorbic
commented
Apr 21, 2023
LekoArts
added
topic: source-drupal
TylerBarnes
previously approved these changes
Apr 21, 2023
|
I've updated to capitalise the typePrefix, and at the same time optimised isFileNode |
TylerBarnes
previously approved these changes
Apr 25, 2023
|
Unit tests are failing (valid) |
|
@LekoArts tests are now passing |
LekoArts
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for type prefixes to the Drupal source plugin. When set, all types generated by the plugin are prefixed with that value. This is analogous to similar options in the Shopify and WordPress plugins.
Documentation
I've added it to the README
Related Issues