Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchPath seems to be broken since adapters #38883

Open
2 tasks done
laurenskling opened this issue Mar 2, 2024 · 0 comments
Open
2 tasks done

matchPath seems to be broken since adapters #38883

laurenskling opened this issue Mar 2, 2024 · 0 comments
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer type: bug An issue or pull request relating to a bug in Gatsby

Comments

@laurenskling
Copy link
Contributor

Preliminary Checks

Description

No boom:
https://feature-back-to-5-11--abmulderbv.netlify.app/searchagent/unsubscribe/354689y324985674398752348/email@example.com

Boom:
https://abmulderbv.netlify.app/searchagent/unsubscribe/354689y324985674398752348/email@example.com
(before hydration, you see the page working correctly from SSR)

Building the site locally and running serve it works as well on 5.13

I create the page like:

    createPage({
      path: `${searchagentPage.slug}/unsubscribe`,
      matchPath: `${searchagentPage.slug}/unsubscribe/:id/:email`,
      component: unsubscribeTemplate,
      context: {
        id: searchagentPage.id,
      },
    });

I just now realised it doesn't work anymore. It must be since adapters in 5.12

Reproduction Link

x

Steps to Reproduce

  1. have a matchPath created page.
  2. go to it.
  3. see it go boom.
    ...

Expected Result

No boom.

Actual Result

boom.

Environment

System:
    OS: macOS 13.6.1
    CPU: (8) arm64 Apple M2
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.19.1 - /var/folders/50/3fndm5d13gs_kr96nwxpxd9c0000gn/T/yarn--1709413201340-0.6552245016050171/node
    Yarn: 1.22.19 - /var/folders/50/3fndm5d13gs_kr96nwxpxd9c0000gn/T/yarn--1709413201340-0.6552245016050171/yarn
    npm: 10.2.4 - /usr/local/bin/npm
  Languages:
    Python: 3.10.9 - /usr/local/bin/python
  Browsers:
    Chrome: 122.0.6261.94
    Safari: 17.1

Config Flags

No response

@laurenskling laurenskling added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 2, 2024
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

1 participant