Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gatsby-theme-i18n] LocalizedLink incorrect type definition #171

Open
pettinarip opened this issue Aug 8, 2022 · 0 comments
Open

[gatsby-theme-i18n] LocalizedLink incorrect type definition #171

pettinarip opened this issue Aug 8, 2022 · 0 comments

Comments

@pettinarip
Copy link

The LocalizedLink component is requiring a language prop. https://github.com/gatsbyjs/themes/blob/master/packages/gatsby-theme-i18n/index.d.ts#L18

Expected
The language prop should be optional since if you don't send it, it fallback into the locale found in the context https://github.com/gatsbyjs/themes/blob/master/packages/gatsby-theme-i18n/src/components/localized-link.js#L8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pettinarip