Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-modified-files-only ignores the folder-path #72

Open
polarweasel opened this issue Sep 22, 2020 · 8 comments
Open

check-modified-files-only ignores the folder-path #72

polarweasel opened this issue Sep 22, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@polarweasel
Copy link

polarweasel commented Sep 22, 2020

If I set check-modified-files-only: true, the link checker ignores the folder-path I have set.

Here's the workflow:

link_checker:
  # https://github.com/gaurav-nelson/github-action-markdown-link-check
  runs-on: ubuntu-latest
  steps:
  - name: Checkout
    uses: actions/checkout@v2
    with:
      submodules: false
  - name: Check markdown links
    uses: gaurav-nelson/github-action-markdown-link-check@master
    with:
      config-file: .mlc_config.json
      # only check the docs folder
      folder-path: 'docs'
      use-quiet-mode: yes
      use-verbose-mode: yes
      check-modified-files-only: yes

This repository includes a bunch of old files that we're not publishing, in a folder called .unpublished. These files are bound to have dead links.

Sample run output. Note the FOLDER_PATH, and the very first file it checks:

Using markdown-link-check configuration file: .mlc_config.json
USE_QUIET_MODE: yes
USE_VERBOSE_MODE: yes
FOLDER_PATH: docs
MAX_DEPTH: -1
CHECK_MODIFIED_FILES: yes
FILE_EXTENSION: .md
FILE_PATH: 
BASE_BRANCH: master
From https://github.com/[redacted]
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
=========================> MARKDOWN LINK CHECK <=========================

FILE: .unpublished/events-08-19/functions/libraries.md
[✖] https://<servername removed>/docs/platform/functions/ → Status: 404

[...further lines removed...]
@gaurav-nelson gaurav-nelson added the bug Something isn't working label Oct 7, 2020
@gaurav-nelson
Copy link
Owner

@polarweasel Could you report if this is still an issue with version 1.0.12 ?

@SteveMattar
Copy link

same for file-path

@polarweasel
Copy link
Author

@gaurav-nelson Figures, I just left that job this week :(

I will point a colleague to this issue and see if he can test!

@techwritermat
Copy link

@gaurav-nelson @polarweasel sorry it took so long, this is still an issue sadly

@gaurav-nelson
Copy link
Owner

Thank @techwritermat I think I now understand what's going on, I'll try to resolve this.

@polarweasel
Copy link
Author

Awesome! I'm about to start using this action at Yugabyte too, and I can guarantee we'll hit the same issue, so it'd be great to have this one resolved. :)

@polarweasel
Copy link
Author

@gaurav-nelson any updates on this one?

@gaurav-nelson
Copy link
Owner

@polarweasel Lately I've been busy with work. I was working on #104 but didn't finish it. Right now I don't know when I can get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants