Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov uploading broke on April 12 #58

Closed
scpeters opened this issue Jun 3, 2022 · 3 comments
Closed

Codecov uploading broke on April 12 #58

scpeters opened this issue Jun 3, 2022 · 3 comments

Comments

@scpeters
Copy link
Contributor

scpeters commented Jun 3, 2022

Something broke in our codecov results around April 12th. I've managed to identify the date by looking at the coverage results from commits before and after this approximate date:

ign-math6

Screen Shot 2022-06-03 at 4 43 24 PM

Screen Shot 2022-06-03 at 4 50 26 PM

ign-gazebo6

Screen Shot 2022-06-03 at 4 48 31 PM

Screen Shot 2022-06-03 at 4 45 36 PM

I'll see if I can narrow it down further on that day

@scpeters
Copy link
Contributor Author

scpeters commented Jun 4, 2022

@scpeters
Copy link
Contributor Author

scpeters commented Jun 4, 2022

ok, I think was fixed by #56 on the focal branch of action-gz-ci since the underlying issue ( actions/checkout#760 ) was reported on April 12th. I will port #56 to the other branches of action-gz-ci since some packages are still creating code coverage on bionic

@scpeters
Copy link
Contributor Author

scpeters commented Jun 4, 2022

since #56 was merged, garden repositories have been getting good coverage results since they are using the focal branch, so I'm porting the fix to bionic in #60

Screen Shot 2022-06-03 at 5 37 07 PM

@scpeters scpeters closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant