Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore retry option when --update-refs is passed #423

Closed
Hypnosphi opened this issue Jul 19, 2019 · 2 comments
Closed

Ignore retry option when --update-refs is passed #423

Hypnosphi opened this issue Jul 19, 2019 · 2 comments
Assignees

Comments

@Hypnosphi
Copy link

It doesn't make much sense to retry when you want to update refs

@timmarinin
Copy link

@Hypnosphi: it does in the case of flaky infrastructure.

@DudaGod DudaGod self-assigned this Mar 7, 2024
@DudaGod
Copy link
Member

DudaGod commented May 13, 2024

Hello guys. Option retry is not ignored because the browser may not start or any other error may occur during the test. So in these cases a screenshot comparison inside test may not be performed. To my mind, option retry should be managed by the user himself.

Do you have any counterarguments?

btw, sorry that it took so long to respond.

@DudaGod DudaGod closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants