Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Некорректный тип browser.executionContext.hermioneCtx #840

Closed
dicrtarasov opened this issue Feb 3, 2024 · 2 comments
Closed
Assignees
Labels

Comments

@dicrtarasov
Copy link

dicrtarasov commented Feb 3, 2024

Описание типа в hermione/build/src/browser/types.d.ts:

executionContext: (RunnerTest | RunnerHook) & {
    hermioneCtx: {
        assertViewResults: Array<AssertViewResult>;
    },
    ....
};

делаю:

console log(browser.executionContext.hermioneCtx)

в случае если нет ошибок, получаю:

{}

В случае ошибки assertView получаю:

{
  "_results": [
    "ImageDiffError": "images are different for \"otkrili_stranitsu_nastroyki_na_ovnere\" state...",
    "stateName": "otkrili_stranitsu_nastroyki_na_ovnere",
    ...
  ]
}

Отсутствие поля assertViewResults недопустимо, согласно типу hermioneCtx.
Или оно было переименовано почему-то в _results?
И это поведение поменялось из версии 7 в версию 8.

Версия hermione: 8.0.5

@DudaGod DudaGod self-assigned this Feb 6, 2024
@DudaGod
Copy link
Member

DudaGod commented Feb 7, 2024

Привет. Проблему воспроизвел. В ближайшее время исправим.

@DudaGod
Copy link
Member

DudaGod commented May 15, 2024

Fixed in hermione@8.9.2 (and testplane@8.11.2)

@DudaGod DudaGod closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants