Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest Lists incorrectly queried from Docker Hub #190

Open
cquon opened this issue Jun 18, 2019 · 1 comment · May be fixed by #191
Open

Manifest Lists incorrectly queried from Docker Hub #190

cquon opened this issue Jun 18, 2019 · 1 comment · May be fixed by #191
Labels
bug

Comments

@cquon
Copy link

cquon commented Jun 18, 2019

I was using the registry client to query manifests / manifest lists from Docker Hub. By only setting the "Accept" header to schema2 manifests, manifest lists were not correctly being returned.

ie:

$ reg manifest alpine
INFO[0000] domain: docker.io
INFO[0000] server address: https://registry-1.docker.io
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
   "config": {
     "mediaType": "application/vnd.docker.container.image.v1+json",
     "size": 1512,
     "digest": "sha256:055936d3920576da37aa9bc460d70c5f212028bda1c08c0879aedf03d7a66ea1"
   },
   "layers": [
     {
       "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
       "size": 2757034,
       "digest": "sha256:e7c96db7181be991f19a9fb6975cdbbd73c65f4a2681348e63a141a2192a5f10"
     }
   ]
 }

When the alpine image is indeed a manifest list.

I have a follow up PR for this.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug label Jun 18, 2019
@cquon cquon linked a pull request Jun 18, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multiple Accept headers to Manifest query cquon/reg
1 participant
@cquon