Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for HTTPS and WMS issues of gh-pages to master #372

Open
chrismayer opened this issue Nov 26, 2015 · 6 comments
Open

Backport fixes for HTTPS and WMS issues of gh-pages to master #372

chrismayer opened this issue Nov 26, 2015 · 6 comments

Comments

@chrismayer
Copy link
Contributor

Due to 'Mixed Content' issues when opening the online examples with HTTPS and some broken WMS references in the online examples several fixes have been made in the gh-pages branch to make the online examples work again (see #359 and #371).

These fixes should be ported to the master branch as well, so they won't be lost on the next update of the gh-pages branch. The following commits should be the base for the backport:

@marcjansen
Copy link
Member

Do we still need to do this?

@chrismayer
Copy link
Contributor Author

I think it is an important reminder for the backport of the HTTPS stuff in gh-pages branch.
Doing the backport itself would be the better option of course 😉 Someone volunteering?

@marcjansen
Copy link
Member

Yeah, I wasn't sure if we had done it. So this is still open. I'd prefer someone else doing it 😇

@bentrm
Copy link
Member

bentrm commented Feb 28, 2016

Would it be ok to load OpenLayers from a CDN that supports https? This way, OpenLayers can be removed in the gh-pages branch and will be available executing the examples locally. Thinking about cdnjs.

@marcjansen
Copy link
Member

Yes that would be ok

@chrismayer
Copy link
Contributor Author

OK for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants