Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Deprecated for Return type in system/src/Grav/Common/Filesystem with PHP 8.3.6 #3831

Open
NoNoNo opened this issue May 5, 2024 · 1 comment

Comments

@NoNoNo
Copy link

NoNoNo commented May 5, 2024

❯ php -v
PHP 8.3.6 (cli) (built: Apr 10 2024 14:21:20) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.6, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.6, Copyright (c), by Zend Technologies
    with Xdebug v3.3.1, Copyright (c) 2002-2023, by Derick Rethans

❯ git clone "https://github.com/getgrav/grav.git" && cd "grav"

❯ fd --glob "*.php" . -0 | xargs -0 php -l | grep -v 'No syntax errors detected'
PHP Deprecated:  Return type of Grav\Common\Filesystem\RecursiveDirectoryFilterIterator::getChildren() should either be compatible with RecursiveFilterIterator::getChildren(): ?RecursiveFilterIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./system/src/Grav/Common/Filesystem/RecursiveDirectoryFilterIterator.php on line 75
PHP Deprecated:  Return type of Grav\Common\Filesystem\RecursiveDirectoryFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./system/src/Grav/Common/Filesystem/RecursiveDirectoryFilterIterator.php on line 52

Deprecated: Return type of Grav\Common\Filesystem\RecursiveDirectoryFilterIterator::getChildren() should either be compatible with RecursiveFilterIterator::getChildren(): ?RecursiveFilterIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./system/src/Grav/Common/Filesystem/RecursiveDirectoryFilterIterator.php on line 75

Deprecated: Return type of Grav\Common\Filesystem\RecursiveDirectoryFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./system/src/Grav/Common/Filesystem/RecursiveDirectoryFilterIterator.php on line 52
PHP Deprecated:  Return type of Grav\Common\Filesystem\RecursiveFolderFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./system/src/Grav/Common/Filesystem/RecursiveFolderFilterIterator.php on line 48

Deprecated: Return type of Grav\Common\Filesystem\RecursiveFolderFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ./system/src/Grav/Common/Filesystem/RecursiveFolderFilterIterator.php on line 48
@rhukster
Copy link
Member

rhukster commented May 6, 2024

How about a pull requests with the deprecations fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants