Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

contrib: break out tests into separate files for each plugin #36

Open
getify opened this issue May 29, 2014 · 6 comments
Open

contrib: break out tests into separate files for each plugin #36

getify opened this issue May 29, 2014 · 6 comments
Assignees

Comments

@getify
Copy link
Owner

getify commented May 29, 2014

In addition, bundle.js needs to optionally include a test only if building with the plugin in question.

@getify getify self-assigned this May 29, 2014
@legodude17
Copy link

Maybe you should have to files: bundle.js and bundle-test.js.

@getify
Copy link
Owner Author

getify commented Jul 28, 2016

I actually don't think the tests need to be bundled. I need to figure out how to get npm test to figure out which tests are appropriate to run or not.

@legodude17
Copy link

So one test file for each plugin, then a single test file that will run the tests that are given by some prereq? What would that be? The ones bundled? User selected? Don't know?

@getify
Copy link
Owner Author

getify commented Jul 28, 2016

Shrugs. I think maybe all plugins present... but then, someone may build a subset (supported by bundle) and want to test only those. Not sure. what to do here. That's why it's an open issue for so long.

@legodude17
Copy link

I was thinking about a --test option to bundle.js. The default would be all, but otherwise you could specify which tests you want.

@getify
Copy link
Owner Author

getify commented Jul 31, 2016

That could work. If you specify, it tests your bundle (maybe before writing to the file?) but if not, the npm test command tests all in the one big bundle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants