Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not build with strict includes #419

Open
knapsu opened this issue May 17, 2024 · 2 comments
Open

Plugin does not build with strict includes #419

knapsu opened this issue May 17, 2024 · 2 comments

Comments

@knapsu
Copy link
Contributor

knapsu commented May 17, 2024

Plugin fails to build when strict include checks are enabled. This can be easily tested with UAT command

.\RunUAT.bat BuildPlugin -Plugin="{workspacePath}\Engine\Plugins\SocketIOClient\SocketIOClient.uplugin" -StrictIncludes -Package="{workspacePath}\LocalBuilds"

What -StrictIncludes does is adding -DisableUnity -NoPCH -NoSharedPCH to UBT when compiling. This ensures that each code file has all the needed includes and therefore is of a good quality on that side.

Will create a pull request that fixes some of the issues.

@knapsu
Copy link
Contributor Author

knapsu commented May 17, 2024

Pull request created. This is a partial fix because there is still a thing with sio_socket.h that I was unable to solve.

@getnamo
Copy link
Owner

getnamo commented May 20, 2024

Good idea, thanks for getting the PR done; merged the includes update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants