CommandInterface misses getHandler() method

[nikic]

CommandInterface is missing the getHandler() method, which is needed to do anything useful with the getCommand() return value.

Unfortunately, adding the method is technically a breaking change :/

[tflori]

For library it is not neccessary, that a command has a handler. It is just an object that is returned if the user enters the name as an argument.

What you do with it is up to you. You can define your own CommandInterface that extends the one from getopt-php and defines this get handler or handle method. I for my part like a handle method more than a getHandler method.

[nikic]

In that case, what is the recommended way of using the getCommand() return value in a type-safe way?

What I'm currently doing is basically this:

$command = $getOpt->getCommand();
if (!$command) {
   // Error
}

$command->getHandler()($getOpt);

But this doesn't type check, because getCommand() returns CommandInterface, which does not have getHandler().

I do agree that requiring getHandler() in particular is maybe not ideal, but I feel like there should be some standardized interface (e.g. a handle() method) for invoking the command. Otherwise using getCommand() would always require a check that the Command is of some more specific type, kind of defeating the point of having an interface for it.

[tflori]

Personally I have an abstract command class that defines a handle method and I prefer it that way. But it would be a breaking change that a handle method is required by the interface.

But what I'm most afraid is that the actions will not work anymore and I'm very much bored of that crap from github (had to change it first to github actions because travis said pay or leave and now the pipelines don't work anymore because they introduce breaking changes without proper versioning). So at the moment I'm not doing anything. If you want you can create a MR to fix the actions and a MR to introduce a handle method for the next major release.