Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compound file extensions #2780

Closed
3 tasks done
GiovanH opened this issue Jul 12, 2020 · 6 comments · May be fixed by #2816
Closed
3 tasks done

Support compound file extensions #2780

GiovanH opened this issue Jul 12, 2020 · 6 comments · May be fixed by #2816
Labels
enhancement stale Marked for closure due to inactivity

Comments

@GiovanH
Copy link
Contributor

GiovanH commented Jul 12, 2020

  • I have searched the issues (including closed ones) and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.
  • I am willing to lend a hand to help implement this feature.

Feature Request

Currently, the file extension matcher used by pelican.readers will only match traditional file extensions. If you want to match files that end in .md.html, and you specify md.html as the desired file extension, the reader will still read file.md.html as an .html file, and as not matching.

This is specifically prompted by Markdeep's standard .md.html file extension.

@justinmayer
Copy link
Member

Hi Gio. Setting aside for a moment Markdeep's perplexing .md.html file extension choice… In Pelican's nearly decade-long existence, I'm not aware of anyone voicing a need for compound file extensions. In other words, this is an edge case that Pelican maintainers most likely cannot allocate time to implement. Is this a feature you would like to work on?

@stale
Copy link

stale bot commented Oct 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

@stale stale bot added the stale Marked for closure due to inactivity label Oct 2, 2020
@GiovanH
Copy link
Contributor Author

GiovanH commented Oct 5, 2020

This should not be closed. It is an open enhancement that can be done. I'd be happy to do it myself if I get the time.

Regardless, unless the decision has been actively made that this shouldn't be added, this shouldn't be closed.

@stale stale bot removed the stale Marked for closure due to inactivity label Oct 5, 2020
@justinmayer justinmayer changed the title Support matching file extensions that include . Support compound file extensions Oct 5, 2020
@justinmayer
Copy link
Member

I understand your perspective. From a maintainer point-of-view, leaving issues open indefinitely when nobody has expressed an interest in working on them leads to a repository full of ancient, dusty, and forgotten issues. Those accumulated dead issues eventually impose a significant maintenance burden on maintainers, and that's why the stale bot was put into service.

I understand that you would like to see Pelican support compound file extensions, and if you would like to work on implementing that functionality (including documentation, tests, etc.), we would be happy to receive and review your contribution to that end. 💫

@holden-nelson
Copy link

I'm looking to make a contribution, but I'm still getting familiar with Pelican. I'd be happy to work on this issue once I'm more up to speed. Would you still accept a pull request for this issue? Assuming it includes documentation, tests, etc.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

@stale stale bot added the stale Marked for closure due to inactivity label Dec 25, 2020
@stale stale bot closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Marked for closure due to inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants