Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document signal argument classes #3150

Open
1 task done
sebbASF opened this issue Jun 19, 2023 · 5 comments
Open
1 task done

Document signal argument classes #3150

sebbASF opened this issue Jun 19, 2023 · 5 comments
Labels

Comments

@sebbASF
Copy link

sebbASF commented Jun 19, 2023

  • I have searched the issues (including closed ones) and believe that this is not a duplicate.

Issue

There is a list of signals and their arguments here:

List of signals

It would help to provide a link to the actual class names.
For example, what is a metadata argument? Is it a class defined by Pelican? I suspect it is just a dict, but this is not obvious.

Likewise 'pelican object'. This is presumably the class defined here:

class Pelican:

Similarly for all the other argument descriptions.

@sebbASF sebbASF added the docs label Jun 19, 2023
@justinmayer
Copy link
Member

Hi @sebbASF. While I understand how additional clarity about these arguments would be helpful, perma-linking to class names in specific-point-in-time SHA hashes doesn’t seem like a maintainable solution. Folks would follow the links and think they are looking at current code, when in fact years could have passed, and the class behavior could have changed dramatically.

An alternative approach could be to create a new table in the documentation that describes these arguments in more detail, and the argument names in the above-mentioned signals table could link to the argument descriptions in this new table. Someone would have to volunteer to create this new table, however, as we Pelican maintainers are already over-committed. 😅

@sebbASF
Copy link
Author

sebbASF commented Jun 22, 2023

A separate table would be fine.
Once the class names are documented, users can at least search the source for the class name.

Better would be links to documentation such as PyDoc

@justinmayer
Copy link
Member

@sebbASF: Is that something you would be willing to help out with?

@sebbASF
Copy link
Author

sebbASF commented Jun 22, 2023

Yes, I should be able to do some of the work

@sebbASF
Copy link
Author

sebbASF commented Jul 3, 2023

Here is my sample table showing the classes for each of the argument names in the signals table.
args.txt

Sorry, but I don't know how to link the entries to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants