New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document signal argument classes #3150
Comments
Hi @sebbASF. While I understand how additional clarity about these arguments would be helpful, perma-linking to class names in specific-point-in-time SHA hashes doesn’t seem like a maintainable solution. Folks would follow the links and think they are looking at current code, when in fact years could have passed, and the class behavior could have changed dramatically. An alternative approach could be to create a new table in the documentation that describes these arguments in more detail, and the argument names in the above-mentioned signals table could link to the argument descriptions in this new table. Someone would have to volunteer to create this new table, however, as we Pelican maintainers are already over-committed. 😅 |
A separate table would be fine. Better would be links to documentation such as PyDoc |
@sebbASF: Is that something you would be willing to help out with? |
Yes, I should be able to do some of the work |
Here is my sample table showing the classes for each of the argument names in the signals table. Sorry, but I don't know how to link the entries to each other. |
Issue
There is a list of signals and their arguments here:
pelican/docs/plugins.rst
Line 128 in 1f6b344
It would help to provide a link to the actual class names.
For example, what is a metadata argument? Is it a class defined by Pelican? I suspect it is just a dict, but this is not obvious.
Likewise 'pelican object'. This is presumably the class defined here:
pelican/pelican/__init__.py
Line 42 in 1f6b344
Similarly for all the other argument descriptions.
The text was updated successfully, but these errors were encountered: