puppeteer issue with Apple Silicon chips

[square-li]

Issue Summary

With Apple Silicon chips (ARM), execute yarn to install dependencies will fail like

error /Users/.../redash/node_modules/puppeteer: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /Users/.../redash/node_modules/puppeteer
Output:
The chromium binary is not available for arm64:
If you are on Ubuntu, you can install with:
 apt-get install chromium-browser

Steps to Reproduce

1. run yarn on MacBook with Apple Silicon

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?

Technical details:

• Redash Version: latest pull from github
• Browser/OS: MacOS 14.4.1 (23E224)
• How did you install Redash: https://github.com/getredash/redash/wiki/Local-development-setup

[square-li]

My temporary solution:

Following this guide: puppeteer/puppeteer#6634 (comment)

OR TLDR:

add these to package.json file

"resolutions": {
    "puppeteer": "https://github.com/seanaye/puppeteer/releases/download/v5.5.0-apple-silicon/puppeteer-core-5.5.0-post.tgz"
},

[justinclift]

@gaecoli From memory, you use macOS yeah?

If that's the case, then this ^^^ sounds like it'll be useful and we could add it to the package.json. 😄

[justinclift]

@square-li Thanks heaps, that does sound useful. 😁

[square-li]

From what I understand, that package is used for frontend automated test. If anyone who just wants to test and run the app, they shouldn't be blocked on this.

[gaecoli]

@gaecoli From memory, you use macOS yeah?

If that's the case, then this ^^^ sounds like it'll be useful and we add it to the package.json. 😄

The same result.

[gaecoli]

@justinclift This seems to be a problem and we should look at how to fix it. 😄

[gaecoli]

puppeteer/puppeteer#6622

I have found some solutions, but it's best to allow users to install dependencies directly through yarn without doing any extra work.

[justinclift]

No worries. It sounds like we should create an extra page on the wiki for people using macOS, so we can give people the macOS specific steps.

If there's not much difference to the main "Local dev setup" page then we don't have to include the whole thing, we can just tell people what differences to install first or something.

What do you reckon? 😄

[justinclift]

If anyone who just wants to test and run the app ...

That kind of sounds like "people who just want to use the app rather than develop it". If that's what you're meaning (?), then for that situation we should probably extend the official setup.sh repository scripting to support macOS.

That might not be too hard. Not really sure yet though as I've not tried it. 😄

[justinclift]

... it's best to allow users to install dependencies directly through yarn without doing any extra work.

Yeah, I think we're in agreement here. If we can update things to automatically work for people so they don't need to follow extra instructions, that would be best.

If "automatic" doesn't work though, then at least having extra instructions for macOS users is probably the right approach.

[gaecoli]

... it's best to allow users to install dependencies directly through yarn without doing any extra work.

Yeah, I think we're in agreement here. If we can update things to automatically work for people so they don't need to follow extra instructions, that would be best.

If "automatic" doesn't work though, then at least having extra instructions for macOS users is probably the right approach.

Ok

[square-li]

@gaecoli From memory, you use macOS yeah?

If that's the case, then this ^^^ sounds like it'll be useful and we add it to the package.json. 😄

The same result.

Sorry I was missing to mention you would need to install chromium for arm as well.

"brew install chromium" then modify the package.json solves my issue.

[justinclift]

@square-li Any interest in creating a new page on the wiki with instructions for macOS users trying to get a dev environment set up? 😄

[square-li]

@square-li Any interest in creating a new page on the wiki with instructions for macOS users trying to get a dev environment set up? 😄

For sure. I would love to.

[justinclift]

Awesome, please do. You should already have the right permissions for making changes on the wiki, and if you hit issues or have questions then please ask here or anywhere else suitable. 😄

If Discord is your kind of thing, then we have a chat server for developers to discuss stuff. You're welcome to join it:

    https://discord.gg/tN5MdmfGBp

[wtfiwtz]

On Node >=18:

PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 yarn add puppeteer
node node_modules/puppeteer/install.mjs

Based on this: puppeteer/puppeteer#6622 (comment)

I was also able to change @percy/agent to @percy/cli to resolve this but it broke some tests, so that needs more investigation time.

[justinclift]

Cool, that looks potentially useful too. Thanks @wtfiwtz. 😄

[gaecoli]

Cool! This good to me.

[AndrewChubatiuk]

added PR #6912, which upgrades percy and cypress, which fixes this issue. please test it if it works for you