Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using milknake to build an sdist instead of a bdist_wheel #17

Open
bcmyers opened this issue Jun 8, 2018 · 1 comment
Open

Using milknake to build an sdist instead of a bdist_wheel #17

bcmyers opened this issue Jun 8, 2018 · 1 comment

Comments

@bcmyers
Copy link

bcmyers commented Jun 8, 2018

Thanks so much for creating tools for the Rust/Python ecosystem!

I was using setuptools-rust and cffi to package some Rust code with Python. I tried to switch over to milksnake but ran into a problem (that might be inherent to milksnake or might be due to my misunderstanding how to use the library - not sure which).

Anyway, I can only distribute an sdist of my Python package because the underlying Rust code calls some underlying C code that uses SIMD instructions; so, in order to get full speed, I need users to compile natively on their own machine at the moment of "pip install ...". This is painful of course because Rust compile times are relatively slow, but the library runs ~50%+ faster after compiling to CPU-specific code; so hopefully the trade off is worth it.

So I got milksnake to work just fine when trying to build a bdist_wheel, but I couldn't figure out how to make it do a simple sdist that gets compiled on-the-fly so-to-speak when users pip install. Is this possible? If not, perhaps it's a possible feature addition.

Thanks again!

@mitsuhiko
Copy link
Member

sdist builds should work. What are you running into here? Just make them install the sdist and it will compile on install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants