feat(measurements): collect heap usage #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/feat/memory-usage
branch
from
62bbd87
to
8f272fe
Compare
JonasBa
commented
Aug 15, 2023
JonasBa
changed the title
indragiek
approved these changes
Aug 18, 2023
* ref(heapticker): generalize the ticker * feat(metrics): collect cpu usage * ref(review): remove statics * ref(review): remove statics * ref(cleanup): rename param * ref(cleanup): free * test: handle segfault * test str * test str * test str * test str * test removing listeners * explicit init * explicit init * test(measurements): add tests * fix(ticker): adjust count * fix(ticker): remove segfault handler * fix(ticker): remove segfault handler * fix(cpp): remove compiler warning * fix(cpp): add remove safety so we dont overflow max measurements
JonasBa
commented
Sep 5, 2023
| // If for some reason stopProfiling was called with an invalid profile title or | ||
| // if that title had somehow been stopped already, profile will be null. | ||
| if (!profile) { | ||
| if (!cpu_profile) { | ||
| napi_throw_error(env, "NAPI_ERROR", "StopProfiling: Stopping Sentry profile did not return a profile."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect heap memory usage at 10hz / every 100ms.
Initializes a single ticking timer which delegates collecting of memory usage stats to each profile.