Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations of CallList #593

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

ziima
Copy link
Contributor

@ziima ziima commented Oct 12, 2022

With 0.22.0, mypy started to complain about constructions rsps.calls[0].request with an error

Item "List[Call]" of "Union[Call, List[Call]]" has no attribute "request"  [union-attr]

because it wasn't able to differentiate between the return types. I added overload annotation to handle that.

@beliaev-maksim
Copy link
Collaborator

hi, thanks

please add new version in changelog and add your item there

@ziima
Copy link
Contributor Author

ziima commented Oct 12, 2022

Done.

@markstory markstory merged commit 26bb973 into getsentry:master Oct 12, 2022
@markstory
Copy link
Member

Thank you 🎉

@andersk
Copy link

andersk commented Dec 4, 2022

When you get a chance, it’d be great to get a new PyPI release, since none of the existing releases work with mypy (#552 for ≤ 0.20.0, #556 for 0.21.0, this for 0.22.0) and current Git works.

@beliaev-maksim
Copy link
Collaborator

closes #610

@howamith howamith mentioned this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants