Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore errors in style observers #16

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 18, 2023

We keep getting errors from the stylesheet observer callback. So let's try catch these to be safe.

@mydea mydea requested review from billyvg and Lms24 January 18, 2023 09:40
@mydea mydea self-assigned this Jan 18, 2023
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead fix the issue directly? I'm worried we end up masking an error (at the risk of having these errors bubble up to our customer accounts)

https://github.com/getsentry/rrweb/blob/sentry-v1/packages/rrweb/src/record/observer.ts#L599-L600

https://github.com/getsentry/rrweb/blob/sentry-v1/packages/rrweb/src/record/observer.ts#L657-L658

@mydea
Copy link
Member Author

mydea commented Jan 18, 2023

The problem is that there is nothing about these lines of codes that should error out. So it's kind of hard to fix this... I want to open an issue in rrweb to ask what the whole stylesheet observer thing is actually needed for, what we're not anyhow getting by the mutation observer. That would be interesting to know!

@billyvg
Copy link
Member

billyvg commented Jan 18, 2023

Yeah for whatever reason, win.CSSStyleSheet becomes undefined when we stop the observers.

I don't think MutationObserver can detect changes the the CSS Object Model, that's why the CSS observer is needed.

@mydea
Copy link
Member Author

mydea commented Jan 19, 2023

I don't think MutationObserver can detect changes the the CSS Object Model, that's why the CSS observer is needed.

True, but this really only covers the case where somebody uses the CSS style sheet API directly, e.g.:

let style = window.styleSheets[0];
style.insertRule('body { color: red; }');

Which honestly I didn't even know existed as an API, and I suspect is something used rather rarely (but then again, maybe I am completely missing something here, who knows!). Mutation observers do catch the IMHO more common cases to adjust styles:

  1. Added/changed/removed <style> tags
  2. Added/changed/removes style='xxx' attributes
  3. Added/changed/removed <link href="style.css"> tags

One option (hypothetical) could also be to require users to opt-in to having the style observers. This may reduce overhead and avoid this category of bugs for the majority of users that don't actually need them 🤔

@mydea
Copy link
Member Author

mydea commented Jan 19, 2023

Okay, looking at rrweb history, I guess we probably need this 😅 rrweb-io#177

@mydea mydea merged commit ac67b09 into sentry-v1 Jan 23, 2023
@mydea mydea deleted the fn/ignore-stylesheet-errors branch January 23, 2023 18:56
mergify bot pushed a commit to raviqqe/tasks that referenced this pull request Jan 27, 2023
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript)
from 7.33.0 to 7.34.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/releases"><code>@​sentry/browser</code>'s
releases</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
<h2>7.34.0-beta.0</h2>
<p>This release is a preview build to test out SDK support for the
server-side Next.js <code>app</code> directory.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md"><code>@​sentry/browser</code>'s
changelog</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/279202d54e1e2df14e9c5c643681f33a1cc787e0"><code>279202d</code></a>
release: 7.34.0</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/82fbbc76f7347e7e4eb661d0c0255c72bd1f2f8e"><code>82fbbc7</code></a>
meta: Update changelog for 7.34.0 (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6950">#6950</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/69b46b3dd8dfdc8894d12b8d16c983378f889bcc"><code>69b46b3</code></a>
fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/b86ac10ed7b67bf403c66864a4d714c24699edc5"><code>b86ac10</code></a>
fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/609887999834fd3bdccbbc242cbe7414ce431da3"><code>6098879</code></a>
ci(replay): Collect replay network metrics (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6881">#6881</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/67fec3787eba1e73497a3a4ef5ea89caa73e0fef"><code>67fec37</code></a>
ref(replay): Use Sentry's forked rrweb packages (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6935">#6935</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/77de64e6783568824031a2aa682422078d65fb2c"><code>77de64e</code></a>
feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/a591f517cd6ae036b242ba0950c6023be9b5b0ff"><code>a591f51</code></a>
fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/040ab0ccfde019894613d699dfcc53883ec3da66"><code>040ab0c</code></a>
codeql(config): fix workflow on ignored .md files (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6933">#6933</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/be640ded0be51eb12c3059bf40a736d49014c5dc"><code>be640de</code></a>
chore(docs): Add publishConfig to release checklist (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6934">#6934</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/getsentry/sentry-javascript/compare/7.33.0...7.34.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@sentry/browser&package-manager=npm_and_yarn&previous-version=7.33.0&new-version=7.34.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mergify bot pushed a commit to raviqqe/pomodoro that referenced this pull request Jan 27, 2023
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript)
from 7.33.0 to 7.34.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/releases"><code>@​sentry/browser</code>'s
releases</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
<h2>7.34.0-beta.0</h2>
<p>This release is a preview build to test out SDK support for the
server-side Next.js <code>app</code> directory.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md"><code>@​sentry/browser</code>'s
changelog</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/279202d54e1e2df14e9c5c643681f33a1cc787e0"><code>279202d</code></a>
release: 7.34.0</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/82fbbc76f7347e7e4eb661d0c0255c72bd1f2f8e"><code>82fbbc7</code></a>
meta: Update changelog for 7.34.0 (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6950">#6950</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/69b46b3dd8dfdc8894d12b8d16c983378f889bcc"><code>69b46b3</code></a>
fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/b86ac10ed7b67bf403c66864a4d714c24699edc5"><code>b86ac10</code></a>
fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/609887999834fd3bdccbbc242cbe7414ce431da3"><code>6098879</code></a>
ci(replay): Collect replay network metrics (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6881">#6881</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/67fec3787eba1e73497a3a4ef5ea89caa73e0fef"><code>67fec37</code></a>
ref(replay): Use Sentry's forked rrweb packages (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6935">#6935</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/77de64e6783568824031a2aa682422078d65fb2c"><code>77de64e</code></a>
feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/a591f517cd6ae036b242ba0950c6023be9b5b0ff"><code>a591f51</code></a>
fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/040ab0ccfde019894613d699dfcc53883ec3da66"><code>040ab0c</code></a>
codeql(config): fix workflow on ignored .md files (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6933">#6933</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/be640ded0be51eb12c3059bf40a736d49014c5dc"><code>be640de</code></a>
chore(docs): Add publishConfig to release checklist (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6934">#6934</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/getsentry/sentry-javascript/compare/7.33.0...7.34.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@sentry/browser&package-manager=npm_and_yarn&previous-version=7.33.0&new-version=7.34.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
greboid pushed a commit to puzzad/puzzad that referenced this pull request Jan 27, 2023
Bumps [@sentry/svelte](https://github.com/getsentry/sentry-javascript)
from 7.33.0 to 7.34.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/releases"><code>@​sentry/svelte</code>'s
releases</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
<h2>7.34.0-beta.0</h2>
<p>This release is a preview build to test out SDK support for the
server-side Next.js <code>app</code> directory.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md"><code>@​sentry/svelte</code>'s
changelog</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/279202d54e1e2df14e9c5c643681f33a1cc787e0"><code>279202d</code></a>
release: 7.34.0</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/82fbbc76f7347e7e4eb661d0c0255c72bd1f2f8e"><code>82fbbc7</code></a>
meta: Update changelog for 7.34.0 (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6950">#6950</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/69b46b3dd8dfdc8894d12b8d16c983378f889bcc"><code>69b46b3</code></a>
fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/b86ac10ed7b67bf403c66864a4d714c24699edc5"><code>b86ac10</code></a>
fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/609887999834fd3bdccbbc242cbe7414ce431da3"><code>6098879</code></a>
ci(replay): Collect replay network metrics (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6881">#6881</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/67fec3787eba1e73497a3a4ef5ea89caa73e0fef"><code>67fec37</code></a>
ref(replay): Use Sentry's forked rrweb packages (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6935">#6935</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/77de64e6783568824031a2aa682422078d65fb2c"><code>77de64e</code></a>
feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/a591f517cd6ae036b242ba0950c6023be9b5b0ff"><code>a591f51</code></a>
fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/040ab0ccfde019894613d699dfcc53883ec3da66"><code>040ab0c</code></a>
codeql(config): fix workflow on ignored .md files (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6933">#6933</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/be640ded0be51eb12c3059bf40a736d49014c5dc"><code>be640de</code></a>
chore(docs): Add publishConfig to release checklist (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6934">#6934</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/getsentry/sentry-javascript/compare/7.33.0...7.34.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@sentry/svelte&package-manager=npm_and_yarn&previous-version=7.33.0&new-version=7.34.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
greboid pushed a commit to puzzad/puzzad that referenced this pull request Jan 27, 2023
Bumps [@sentry/tracing](https://github.com/getsentry/sentry-javascript)
from 7.33.0 to 7.34.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/releases"><code>@​sentry/tracing</code>'s
releases</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
<h2>7.34.0-beta.0</h2>
<p>This release is a preview build to test out SDK support for the
server-side Next.js <code>app</code> directory.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md"><code>@​sentry/tracing</code>'s
changelog</a>.</em></p>
<blockquote>
<h2>7.34.0</h2>
<p>This release adds automatic injection of the Next.js SDK into
serverside <code>app</code> directory bundles, allowing users to call
the Sentry SDK in server components.</p>
<ul>
<li>feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li>fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li>fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li>fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><code>getsentry/rrweb#16</code></li>
</ul>
<p>Work in this release contributed by <a
href="https://github.com/mdtro"><code>@​mdtro</code></a>. Thank you for
your contribution!</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/279202d54e1e2df14e9c5c643681f33a1cc787e0"><code>279202d</code></a>
release: 7.34.0</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/82fbbc76f7347e7e4eb661d0c0255c72bd1f2f8e"><code>82fbbc7</code></a>
meta: Update changelog for 7.34.0 (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6950">#6950</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/69b46b3dd8dfdc8894d12b8d16c983378f889bcc"><code>69b46b3</code></a>
fix(replay): Do not renew session in error mode (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6948">#6948</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/b86ac10ed7b67bf403c66864a4d714c24699edc5"><code>b86ac10</code></a>
fix(replay): Handle compression worker errors more gracefully (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6936">#6936</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/609887999834fd3bdccbbc242cbe7414ce431da3"><code>6098879</code></a>
ci(replay): Collect replay network metrics (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6881">#6881</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/67fec3787eba1e73497a3a4ef5ea89caa73e0fef"><code>67fec37</code></a>
ref(replay): Use Sentry's forked rrweb packages (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6935">#6935</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/77de64e6783568824031a2aa682422078d65fb2c"><code>77de64e</code></a>
feat(nextjs): Add SDK to serverside <code>app</code> directory (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6927">#6927</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/a591f517cd6ae036b242ba0950c6023be9b5b0ff"><code>a591f51</code></a>
fix(replay): fix path separator substitution to replay all
<code>\</code> (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6932">#6932</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/040ab0ccfde019894613d699dfcc53883ec3da66"><code>040ab0c</code></a>
codeql(config): fix workflow on ignored .md files (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6933">#6933</a>)</li>
<li><a
href="https://github.com/getsentry/sentry-javascript/commit/be640ded0be51eb12c3059bf40a736d49014c5dc"><code>be640de</code></a>
chore(docs): Add publishConfig to release checklist (<a
href="https://github-redirect.dependabot.com/getsentry/sentry-javascript/issues/6934">#6934</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/getsentry/sentry-javascript/compare/7.33.0...7.34.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@sentry/tracing&package-manager=npm_and_yarn&previous-version=7.33.0&new-version=7.34.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants