Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.32.2
Choose a base ref
...
head repository: getsentry/sentry-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.33.1
Choose a head ref

Commits on Jul 15, 2024

  1. Merge branch 'release/2.32.2'

    getsentry-bot committed Jul 15, 2024
    Copy the full SHA
    cdf3ebb View commit details

Commits on Jul 17, 2024

  1. build(deps): bump ws from 7.5.9 to 7.5.10 (#2091)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 17, 2024
    Copy the full SHA
    98ba434 View commit details
  2. feat(auth): Recognize new format user tokens (#2100)

    getsentry/sentry#68148 changed user auth tokens, so that they now start with a sntryu_ prefix. While the CLI correctly handles these new tokens, the CLI issued a warning when using these new format tokens.
    
    This PR updates the CLI's auth token parsing logic to recognize the new user auth token format (in addition to the old format), so that the warning is no longer issued.
    szokeasaurusrex authored Jul 17, 2024
    Copy the full SHA
    215f1c9 View commit details
  3. Copy the full SHA
    7af518e View commit details
  4. Copy the full SHA
    2a18157 View commit details
  5. docs(id-support): Document that -p and -o arguments accept slugs and …

    …IDs (#2101)
    
    Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
    iamrajjoshi and szokeasaurusrex authored Jul 17, 2024
    Copy the full SHA
    f20a6a1 View commit details

Commits on Jul 18, 2024

  1. docs: Fix typos (#2102)

    Found via `typos --hidden --format brief`
    kianmeng authored Jul 18, 2024
    Copy the full SHA
    3c6a11f View commit details

Commits on Jul 23, 2024

  1. build: Downgrade symbolic-debuginfo to 12.8.0 (#2108)

    symbolic-debuginfo version 12.8.0 is the latest version excluding getsentry/symbolic#816, which caused a regression in sentry-cli.
    
    Fixes #2107
    szokeasaurusrex authored Jul 23, 2024
    Copy the full SHA
    94c9557 View commit details
  2. release: 2.33.0

    getsentry-bot committed Jul 23, 2024
    Copy the full SHA
    13b351b View commit details
  3. Update CHANGELOG.md

    szokeasaurusrex authored Jul 23, 2024
    Copy the full SHA
    afec7ee View commit details
  4. Merge branch 'release/2.33.0'

    getsentry-bot committed Jul 23, 2024
    Copy the full SHA
    5bcd5b0 View commit details
  5. Copy the full SHA
    6e841db View commit details

Commits on Jul 31, 2024

  1. Copy the full SHA
    d0e8717 View commit details
  2. Fall back to co-location heuristic if sourcemap url appears remote (#…

    …1871)
    
    Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
    brettdh and szokeasaurusrex authored Jul 31, 2024
    Copy the full SHA
    4ab584d View commit details

Commits on Aug 1, 2024

  1. fix: Improve "release not found" message (#2112)

    Clarify that users need to check the release, project, and organization when encountering a "release not found" error, since any of these being wrong can cause a "release not found" error.
    
    Fixes #2111
    szokeasaurusrex committed Aug 1, 2024
    Copy the full SHA
    ee6e728 View commit details
  2. fix: Improve "project not found" message (#2112)

    Update "project not found" message to avoid mentioning "IDs" and "slugs," which might confuse some users. Instead, make this error message follow the same format as the "release not found" message.
    szokeasaurusrex committed Aug 1, 2024
    Copy the full SHA
    8343763 View commit details
  3. ref(token): Separate validation warning from parsing

    Separate logic for issuing the invalid auth token format validation warning from the parsing logic. This will allow us in the future to test whether a certain string might be an auth token without logging a warning.
    szokeasaurusrex committed Aug 1, 2024
    Copy the full SHA
    8ce98a0 View commit details
  4. test: Delete apparently-unnecessary test

    This test does not appear to test any important functionality. Rather, it is primarily asserting that specific messages are logged. Let's remove it so we do not need to update the test if we ever change what these logs state.
    szokeasaurusrex committed Aug 1, 2024
    Copy the full SHA
    61a3294 View commit details
  5. fix: Redact auth tokens when logging CLI args

    Redact anything that might be an auth token when logging the command line arguments to console. This occurs only when the log level is set to `info` or `debug`; the default is `warn`.
    szokeasaurusrex committed Aug 1, 2024
    Copy the full SHA
    2665d8a View commit details
  6. test(tokens): Add test to ensure tokens redacted

    The test ensures that when the CLI args are echoed back, anything which might reasonably be an auth token is redacted.
    szokeasaurusrex committed Aug 1, 2024
    Copy the full SHA
    3d05326 View commit details
  7. ref(token): Use secrecy crate to store auth token (#2116)

    Using the secrecy crate prevents the auth token from accidentally being leaked if we log the AuthToken struct.
    szokeasaurusrex authored Aug 1, 2024
    Copy the full SHA
    8b89630 View commit details

Commits on Aug 2, 2024

  1. fix: Improve token redaction in CLI arg logging

    #2115 aimed to redact auth tokens when logging the arguments to the CLI. Although that change addressed some cases where auth tokens were passed as a CLI argument, not all cases were addressed. For example, the following was redacted properly with #2115:
    
    ```sh
    sentry-cli --auth-token this-gets-redacted --log-level=info info
    ```
    
    But, the following was not:
    
    ```sh
    sentry-cli --auth-token=this-does-not-get-redacted --log-level=info info
    ```
    
    The difference is that in the second example, the auth token is passed with `--auth-token=token` rather than separated by whitespace `--auth-token token`.
    
    This change improves the redacting so that auth tokens passed like `--auth-token=token` are also redacted. The change also redacts any non-whitespace-containing substrings starting with `sntrys_` or `sntryu_` (prefixes that all auth tokens generated in the latest version of Sentry should start with), so that if an auth token appears where it is not expected, we redact it. For example, the following would be redacted with this change:
    
    ```sh
    sentry-cli --auth=sntrys_my-token-passed-as-non-existing-auth-argument --log-level=info info
    ```
    
    Note that as in #2115, this change is only relevant in the case where the log level is set to `info` or `debug` (the default is `warn`) – command line arguments are logged at the `info` level.
    szokeasaurusrex committed Aug 2, 2024
    Copy the full SHA
    5c1ac1f View commit details
  2. meta: Revert upload-artifact bump (#2110) (#2119)

    This reverts commit d0e8717, which bumped upload-artifact to version 4.
    
    Due to actions/upload-artifact#478, upload-artifact version 4 is incompatible with our current release proces. This change is blocking us from successfully creating release builds.
    
    As a workaround, we will revert this change for now.
    szokeasaurusrex authored Aug 2, 2024
    Copy the full SHA
    acb5700 View commit details
  3. release: 2.33.1

    getsentry-bot committed Aug 2, 2024
    Copy the full SHA
    eac9527 View commit details
  4. Update CHANGELOG.md

    szokeasaurusrex committed Aug 2, 2024
    Copy the full SHA
    5aaf7c1 View commit details
Loading