Increase TempFile robustness on Windows #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `FILE_FLAG_DELETE_ON_CLOSE` to delete `TempFile`s on Windows, which will work even if there's an open handle. I wasn't able to isolate this into a specific test case, but in local tests of `upload-dif` this successfully fixes getsentryGH-1250.
loewenheim
approved these changes
Jun 24, 2022
kamilogorek
pushed a commit
that referenced
this pull request
Jun 27, 2022
* Add some rudimentary tests for `TempFile` * Windows: Make `TempFile`'s `Drop` more robust Use `FILE_FLAG_DELETE_ON_CLOSE` to delete `TempFile`s on Windows, which will work even if there's an open handle. I wasn't able to isolate this into a specific test case, but in local tests of `upload-dif` this successfully fixes GH-1250.
This was referenced Jun 27, 2022
kamilogorek
added a commit
that referenced
this pull request
Jun 28, 2022
* Add some rudimentary tests for `TempFile` * Windows: Make `TempFile`'s `Drop` more robust Use `FILE_FLAG_DELETE_ON_CLOSE` to delete `TempFile`s on Windows, which will work even if there's an open handle. I wasn't able to isolate this into a specific test case, but in local tests of `upload-dif` this successfully fixes GH-1250. Co-authored-by: Jørgen P. Tjernø <jorgen@tjer.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses GH-1250 -- it replaces the
Dropimplementation ofTempFilewith one that usesFILE_FLAG_DELETE_ON_CLOSEto defer deletion until the last handle is closed on Windows.This also adds some error logging when
TempFile'sdropfails -- not sure if that's appropriate? It'll help catch issues like this.