Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry is sending non-cloneable JavaScript objects through IPC #214

Closed
astutejoe opened this issue Feb 11, 2020 · 1 comment · Fixed by #215
Closed

Sentry is sending non-cloneable JavaScript objects through IPC #214

astutejoe opened this issue Feb 11, 2020 · 1 comment · Fixed by #215

Comments

@astutejoe
Copy link

Electron 8 started throwing deprecation warnings for IPC method calls that have non-cloneable JavaScript objects as params. This is so they can move to a more efficient serializer from the V8 engine.

You can check more details in here:
electron/electron#20214

From my investigations, Sentry is sending such non-cloneable objects at the following lines:
https://github.com/getsentry/sentry-electron/blob/master/src/renderer/backend.ts#L51
https://github.com/getsentry/sentry-electron/blob/master/src/renderer/backend.ts#L61

It still works on Electron 8, with deprecation warnings, and will stop working on Electron 9 according to their roadmap.

Personal note: I HATE when I have deprecation warnings in my application.

Thanks!

@timfish
Copy link
Collaborator

timfish commented Feb 11, 2020

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants