Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clone request body to new scope #244

Merged
merged 1 commit into from Jul 6, 2020
Merged

fix: clone request body to new scope #244

merged 1 commit into from Jul 6, 2020

Conversation

themez
Copy link
Contributor

@themez themez commented Jun 4, 2020 •
edited

The problem

I applied sentryecho middleware to my echo application, when capturing exception in withScope, the request body was not recorded.

Fix

Assign clone's request body to original scope

@rhcarvalho rhcarvalho self-assigned this Jun 22, 2020
rhcarvalho
rhcarvalho approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @themez

@rhcarvalho rhcarvalho merged commit 7c5f125 into getsentry:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees

@rhcarvalho rhcarvalho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@themez @rhcarvalho