Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): Deprecate HandleFunc, remove duplication #260

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

rhcarvalho
Copy link
Contributor

The Handler.HandleFunc is unnecessary as all uses can be replaced with Handler.Handle (an http.HandlerFunc implements http.Handler).

The Handler.HandleFunc is unnecessary as all uses can be replaced with
Handler.Handle (an http.HandlerFunc implements http.Handler).
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rhcarvalho rhcarvalho merged commit 36c7432 into getsentry:master Jul 17, 2020
@rhcarvalho rhcarvalho deleted the http-code-duplication branch July 17, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants