doc: Revamp sentryhttp documentation #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
force-pushed
the
sentryhttp-example
branch
from
3de525b
to
9757a90
Compare
The major point is to promote instrumenting higher up in the HTTP handler hierarchy, such that Sentry instrumentation takes only one line, instead of wrapping many individual handlers. - Add go doc example with minimal steps for instrumenting web servers. - Overhaul doc comments. - Replace executable example with something a little bit more realistic, which we can build upon to show tracing instrumentation later.
rhcarvalho
force-pushed
the
sentryhttp-example
branch
from
9757a90
to
ddb2893
Compare
kamilogorek
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major point is to promote instrumenting higher up in the HTTP
handler hierarchy, such that Sentry instrumentation takes only one line,
instead of wrapping many individual handlers.
which we can build upon to show tracing instrumentation later.