Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not double sample transactions #328

Merged
merged 2 commits into from Feb 17, 2021
Merged

fix: Do not double sample transactions #328

merged 2 commits into from Feb 17, 2021

Conversation

rhcarvalho
Copy link
Contributor

Transactions should be sampled only by TracesSampleRate or TracesSampler, and the general SampleRate does not apply.

See https://develop.sentry.dev/sdk/performance/#sampling
image

kamilogorek
kamilogorek previously approved these changes Feb 16, 2021
View reviewed changes
client.go Show resolved Hide resolved
@kamilogorek kamilogorek merged commit 7d0542d into master Feb 17, 2021
@kamilogorek kamilogorek deleted the fix-double-sampling branch February 17, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhcarvalho @kamilogorek