Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel Context Missing #596

Closed
smeubank opened this issue Mar 7, 2023 · 5 comments · Fixed by #599 or #605
Closed

OTel Context Missing #596

smeubank opened this issue Mar 7, 2023 · 5 comments · Fixed by #599 or #605
Assignees
Labels
Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration Type: Bug

Comments

@smeubank
Copy link
Member

smeubank commented Mar 7, 2023

Summary

Events sent to Sentry which were converted from OTel spans, should have an OTel context with attributes and other data sourced from OTel SDKs. It appears that some events do not have this.

Python event with context

image

Go event without context

Develop Spec: Add OpenTelemetry Context

Steps To Reproduce

Expected Behavior

OTel SDK data populated in the OTel context and appearing in the product on the transaction detail page

SDK

  • sentry-go with OTel Go SDKs
@smeubank smeubank added Type: Bug Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration labels Mar 7, 2023
@AbhiPrasad AbhiPrasad self-assigned this Mar 8, 2023
@smeubank smeubank linked a pull request Mar 10, 2023 that will close this issue
@cleptric cleptric reopened this Mar 15, 2023
@AbhiPrasad
Copy link
Member

Why did we re-open?

@cleptric
Copy link
Member

Because it's not fixed. We still need to move the txn name away from the scope.

@AbhiPrasad
Copy link
Member

Ah ok - thought we would open up a new issue for this, but this is fine for me as well 👍

@cleptric
Copy link
Member

So this is about "OTel Context Missing", and as we currently always get an empty Hub here https://github.com/getsentry/sentry-go/blob/master/otel/span_processor.go#L120-L123, so even with #599 being merged, it won't work just yet.

@AbhiPrasad
Copy link
Member

Alright I will push up a PR then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration Type: Bug
Projects
None yet
3 participants