Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with GOPATH builds/tests #616

Closed
tonyo opened this issue Mar 30, 2023 · 0 comments · Fixed by #618
Closed

Decide what to do with GOPATH builds/tests #616

tonyo opened this issue Mar 30, 2023 · 0 comments · Fixed by #618
Assignees

Comments

@tonyo
Copy link
Member

tonyo commented Mar 30, 2023

At the moment the GOPATH build fails because opentelemetry-go dep now has 1.19+ symbols (atomic.Bool, atomic.Pointer) in their main branch.

Example https://github.com/getsentry/sentry-go/actions/runs/4563862504/jobs/8052889793

image

Building otel module in that test has been removed here, but we should consider dumping that test altogether, given the fact that it's 2023, and Go modules have been the thing for a long time already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant