Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel] isSentryRequest might return wrong result #627

Closed
cleptric opened this issue Apr 17, 2023 · 0 comments
Closed

[OTel] isSentryRequest might return wrong result #627

cleptric opened this issue Apr 17, 2023 · 0 comments
Assignees
@tonyo
Labels
Status: Backlog Type: Bug

Comments

@cleptric
Copy link
Member

cleptric commented Apr 17, 2023 •
edited by smeubank

https://github.com/getsentry/sentry-go/blob/master/otel/internal/utils/sentryrequest.go#L27-L40

If the hub is not accessible via the ctx, we might fail to mark a Sentry span correctly and send it instead.

  • more specifically this problem may lead to you receiving transactions in Sentry which are relevant only to Sentry SDK internals
  • meaning the endpoints the Go SDK uses POST https://*/api/*/envelope/ & POST https://*/api/*/store/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyo tonyo

Labels
Status: Backlog Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HazAT @tonyo @cleptric