Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Add Span.SetDynamicSamplingContext method #539

Merged
merged 3 commits into from Jan 19, 2023

Conversation

tonyo
Copy link
Member

@tonyo tonyo commented Jan 19, 2023

This PR adds Span.SetDynamicSamplingContext method that allows to set the given dynamic sampling context on a transaction. For spans it does nothings.

This is needed for the OTel work (#537).

@tonyo tonyo requested a review from cleptric January 19, 2023 11:52
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 84.19% // Head: 83.97% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (0770aff) compared to base (4fad7b7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   84.19%   83.97%   -0.23%     
==========================================
  Files          23       23              
  Lines        2816     2820       +4     
==========================================
- Hits         2371     2368       -3     
- Misses        365      370       +5     
- Partials       80       82       +2     
Impacted Files Coverage Δ
tracing.go 82.43% <100.00%> (+0.17%) ⬆️
integrations.go 89.01% <0.00%> (-2.32%) ⬇️
transport.go 78.37% <0.00%> (-0.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo merged commit 52e1547 into master Jan 19, 2023
@tonyo tonyo deleted the tonyo/add-set-dsc-span branch January 19, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants