Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support include and file collection sub-options #62

Closed
5 tasks done
Lms24 opened this issue Oct 20, 2022 · 0 comments
Closed
5 tasks done

Support include and file collection sub-options #62

Lms24 opened this issue Oct 20, 2022 · 0 comments
Assignees
@lforst @Lms24

Comments

@Lms24
Copy link
Member

Lms24 commented Oct 20, 2022 •
edited

include is the most important option option for the plugins and we have to support it properly.
include can either be a simple string, an IncludeEntry or an array with a mixture of strings and entries. Ideally, we normalize the given user option into an internal option and take it from there.

Prework:

Sub-options to support that deal with file collection:

EDIT: moved include file modification options to separate issue (#81)

ref #50
@Lms24 Lms24 mentioned this issue Oct 20, 2022
Closed
@Lms24 Lms24 changed the title Add support for include option including sub-options Support include option plus sub-options Oct 20, 2022
@Lms24 Lms24 mentioned this issue Oct 21, 2022
Merged
Lms24 added a commit that referenced this issue Oct 24, 2022
@Lms24
Add all options including JSDoc to Options type (#66)
f3843b5 
Add all options + JSDoc from the webpack plugin to our `Options` type. 

Changes to Webpack Plugin:
* Remove env variable usage
* Remove configFile property

ref: #62
@lforst lforst mentioned this issue Oct 25, 2022
Merged
This was referenced Oct 28, 2022
Merged
Merged
@Lms24 Lms24 changed the title Support include option plus sub-options Support include file collection options Nov 2, 2022
@Lms24 Lms24 mentioned this issue Nov 2, 2022
Closed
6 tasks
@Lms24 Lms24 changed the title Support include file collection options Support include and file collection sub-options Nov 2, 2022
@Lms24 Lms24 closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lforst lforst

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lforst @Lms24